Skip to content

copy all array_view members in copy constructor #3811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 18, 2014
Merged

copy all array_view members in copy constructor #3811

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bae42a8
copy all array_view members in copy constructor
jbmohler Nov 17, 2014
f94ffd7
Use XINCREF in copy constructor and subview constructor, since arr ma…
mdboom Nov 17, 2014
bbff731
remove unused parameter 'contiguous'
jbmohler Nov 18, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
remove unused parameter 'contiguous'
  • Loading branch information
@jbmohler
jbmohler committed Nov 18, 2014
commit bbff7318842e29f9ab473a1af3c2751fcc2309b4
2 changes: 1 addition & 1 deletion src/numpy_cpp.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,7 +367,7 @@ class array_view : public detail::array_view_accessors<array_view, T, ND>
}
}

array_view(const array_view &other, bool contiguous = false) : m_arr(NULL), m_data(NULL)
array_view(const array_view &other) : m_arr(NULL), m_data(NULL)
{
m_arr = other.m_arr;
Py_XINCREF(m_arr);
Expand Down