Skip to content

Added missing implementation of get_window_extent for AxisImage and test (fixes #2980). #3861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 30, 2014
Merged

Added missing implementation of get_window_extent for AxisImage and test (fixes #2980). #3861

merged 3 commits into from
Nov 30, 2014

Conversation

maxalbert
Copy link
Contributor

No description provided.

@WeatherGod
Copy link
Member

Travis hiccup-ed. It needs a restart.

@pelson
Copy link
Member

pelson commented Nov 29, 2014

Looking good. I'm going to let the tests finish, but I'm 👍.

@pelson
Copy link
Member

pelson commented Nov 29, 2014

Looking good. I'm going to let the tests finish, but I'm 👍.

Spoke too soon. PEP8 test needs fixing (line too long)

@tacaswell
Copy link
Member

Still has PEP8 issue

@tacaswell
Copy link
Member

Should this be back-ported to 1.4.x?

@tacaswell
Copy link
Member 

======================================================================

FAIL: matplotlib.tests.test_coding_standards.test_pep8_conformance_installed_files

----------------------------------------------------------------------

Traceback (most recent call last):

File "/home/travis/virtualenv/python2.7.8/lib/python2.7/site-packages/nose/case.py", line 197, in runTest

self.test(*self.arg)

File "/home/travis/virtualenv/python2.7.8/lib/python2.7/site-packages/matplotlib-1.5.x-py2.7-linux-x86_64.egg/matplotlib/tests/test_coding_standards.py", line 255, in test_pep8_conformance_installed_files

expected_bad_files=expected_bad_files)

File "/home/travis/virtualenv/python2.7.8/lib/python2.7/site-packages/matplotlib-1.5.x-py2.7-linux-x86_64.egg/matplotlib/tests/test_coding_standards.py", line 140, in assert_pep8_conformance

assert_equal(result.total_errors, 0, msg)

AssertionError: Found code syntax errors (and warnings):

/home/travis/virtualenv/python2.7.8/lib/python2.7/site-packages/matplotlib-1.5.x-py2.7-linux-x86_64.egg/matplotlib/image.py:579:80: E501 line too long (83 > 79 characters)

----------------------------------------------------------------------

Ran 2 tests in 21.993s

pelson added a commit that referenced this pull request Nov 30, 2014
@pelson
Merge pull request #3861 from maxalbert/fix_get_window_extent
ca10a34 
Added missing implementation of get_window_extent for AxisImage and test (fixes #2980).
@pelson pelson merged commit ca10a34 into matplotlib:master Nov 30, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
mentored: hackathon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maxalbert @WeatherGod @pelson @tacaswell