MNT : deprecate FigureCanvasBase.onHilite #3988
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c8154da to
6d2a63b
Compare
| @@ -1734,15 +1728,19 @@ def onHilite(self, ev): | |||
|
|
|||
| canvas.mpl_connect('motion_notify_event',canvas.onHilite) | |||
| """ | |||
| msg = ("onHilite has been deprecated in 1.5 and will be removed " | |||
| "in 1.6. This function has not been used internal by mpl " | |||
| "sense 2007.") | |||
There was a problem hiding this comment.
internal --> internally sense --> since
This function has not been used internally since _at least_ 2007.
6d2a63b to
890f2ad
Compare
|
fixed and force-pushed. |
|
I think it is safe to forgo the api changes notice. I do not recall this feature, ever. Merging. |
WeatherGod
added a commit
that referenced
this pull request
Jan 10, 2015
MNT : deprecate FigureCanvasBase.onHilite
|
It looks like it was experimental code that never panned out. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function has not been used internal since at least 2007.
I am inclined to just delete it, but being overly cautious.