Skip to content

fix find_output_cell for IPython >= 3.0 [backport to 1.4.x] #4002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 15, 2015
Merged

fix find_output_cell for IPython >= 3.0 [backport to 1.4.x] #4002

merged 2 commits into from
Jan 15, 2015

Conversation

minrk
Copy link
Contributor

@minrk minrk commented Jan 14, 2015

output mime-type keys moved from top-level to a data attribute.

Added an error-log for the case where output is not found, which should make similar bugs a bit easier to find in the future.

closes ipython/ipython#7351

minrk added 2 commits January 14, 2015 15:56
output mime-type keys moved from top-level to a `data` attribute.
@tacaswell tacaswell changed the title fix find_output_cell for IPython >= 3.0 fix find_output_cell for IPython >= 3.0 [backport to 1.4.x] Jan 15, 2015
@tacaswell tacaswell added this to the v1.4.3 milestone Jan 15, 2015
@tacaswell
Copy link
Member

Thanks!

Also in testing this, it seems that something we did recently fixed the 'click too fast and the figure dies' issue (no idea what or how), but hooray!

tacaswell added a commit that referenced this pull request Jan 15, 2015
BUG : fix find_output_cell for IPython >= 3.0
@tacaswell tacaswell merged commit 80a09cc into matplotlib:master Jan 15, 2015
tacaswell added a commit that referenced this pull request Jan 15, 2015
BUG : fix find_output_cell for IPython >= 3.0
@tacaswell
Copy link
Member

cherry-picked as 7449e85

@pelson
Copy link
Member

pelson commented Jan 19, 2015

Nice. Thanks @minrk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nbagg shows no image
3 participants