Skip to content

Allow interrupts to be delivered once Python is fixed. #4006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 9, 2015
Merged

Allow interrupts to be delivered once Python is fixed. #4006

merged 1 commit into from
Feb 9, 2015
+169 −89

Conversation

mdehoon
Copy link
Contributor

@mdehoon mdehoon commented Jan 17, 2015

This is related to issue #3991. Until now the MacOSX backend did not deliver interrupts while the event loop is running as Python itself would ignore those interrupts anyway. This PR allows interrupts to be delivered once Python is fixed.

@mdehoon mdehoon mentioned this pull request Jan 17, 2015
Closed
@tacaswell
Copy link
Member

@mdehoon Who else knows this code well enough to review it?

@tacaswell tacaswell added this to the v1.5.x milestone Jan 19, 2015
@tacaswell
Copy link
Member

and should this be back-ported to 1.4.x?

@mdehoon
Copy link
Contributor Author

mdehoon commented Jan 21, 2015

@tacaswell Few people have a good understanding of event loops, in particular people coming from a scripting background. This PR is not a major change, so I think getting a review is not critical. I would suggest to wait until Python itself is fixed (because without that, this PR doesn't add any functionality anyway), and after that apply the PR and let some users test it. This PR does not need to be back-ported to 1.4.x.

@mdehoon
Copy link
Contributor Author

mdehoon commented Jan 24, 2015

I have uploaded a patch for Python; see issue 23237 at
http://bugs.python.org/issue23237
With this patch, and this pull request, interrupts will be delivered for the MacOSX backend (and also for Tkinter). I would appreciate it if interested people can give this a try.

@tacaswell
Copy link
Member

Is there harm in merging this before python is fixed?

@mdehoon
Copy link
Contributor Author

mdehoon commented Feb 9, 2015

This can be merged before Python is fixed, so it's OK to merge it now. This pull request also fixes issue #3654 .

tacaswell added a commit that referenced this pull request Feb 9, 2015
@tacaswell
Merge pull request #4006 from mdehoon/allow_interrupts
ee4f072 
BUG : Allow interrupts to be delivered once Python is fixed + path fixes
@tacaswell tacaswell merged commit ee4f072 into matplotlib:master Feb 9, 2015
@tacaswell tacaswell mentioned this pull request Feb 9, 2015
Closed
@mdehoon mdehoon deleted the allow_interrupts branch February 9, 2015 02:52
@cimarronm cimarronm mentioned this pull request Feb 21, 2015
Closed
@anntzer anntzer mentioned this pull request May 24, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
GUI: MacOSX OS: Apple
Projects
None yet
Milestone
v2.1
Development

Successfully merging this pull request may close these issues.
2 participants
@mdehoon @tacaswell