[WIP] Quad mesh extent #3095 #4017
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes matplotlib#3095 Without a `get_window_extent` method defined, it was falling back to the `Collection` version which in turn called (eventually) `covert_mesh_to_paths`, which resulted in a >5x blow up in the memory usage.
|
Addresses #3095 |
|
Tom, I've looked at it a couple times already without understanding it. I think I will need a chunk of time, and it's unlikely I will be able to spare that during the next couple of days, at least. I know, the end-of-the-month target is fast approaching... |
|
@tacaswell - a few months back we updated the add_collection method ( matplotlib/lib/matplotlib/axes/_base.py Line 1477 in bb19e7c |
|
Thanks to @tacaswell & @efiring for the hint. The linked commit (88b722f) was the key. Essentially, I believe all is needed is a get_datalim method on the quadmesh object. #4045 fixes. |
|
Closing in favor of #4045. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think this currently deals with the offsets properly (as it seems that all of the collections will just repeat if the number of paths or the number of offsets (or number of transforms) don't match).
The other option is to just have
QuadMeshreturn a null bounding box for it's size and exclude it from the tight bounding box computation.@mdboom Am I at least headed the right direction?