[WIP] Fix annotation get window extent #4023
Conversation
|
Great! This looks like it will need a re-base to current master already. |
|
I am on it |
Conflicts: lib/matplotlib/tests/test_text.py
|
conflict resolved, please note that I still need to fix and add a couple of tests |
| @image_comparison(baseline_images=['text_bboxclip']) | ||
| def test_bbox_clipping(): | ||
| plt.text(0.9, 0.2, 'Is bbox clipped?', backgroundcolor='r', clip_on=True) | ||
| t = plt.text(0.9, 0.5, 'Is fancy bbox clipped?', clip_on=True) | ||
| t.set_bbox({"boxstyle": "round, pad=0.1"}) | ||
|
|
||
|
|
||
| def test_text_annotation_get_window_extent(): |
There was a problem hiding this comment.
It is easier to add the @cleanup decorator use pyplot to make your figure/axes objects.
There was a problem hiding this comment.
Maybe, I now see why you are doing it this way.
|
I have cherry-picked these over to be based on the 1.4.x branch. I should have a version of this merged in the near future. |
…w-extent BUG : annotation objects did not report their window extent properl
|
Merged in to v1.4.x as 26c7d65 |
|
Thanks @tacaswell. Sorry for the delay. I will make a separate PR for the additional tests. |
|
@itziakos Thanks for your work. Sorry if you feel like I stepped on your toes, I wanted to get this in and this was the fastest path to get there. |
There was no offense taken, It is me who should apologize for the delay. |
This PR reworks
Annotationto provide a get_window_extent method that will return as bounding box the union of the contained text and arrow.Pending: