Correct FA 4 name of Download icon #4051
Conversation
See http://fortawesome.github.io/Font-Awesome/icon/floppy-o/ There is as far as I can see no fa-icon-save in in FA 4.x Resolves an issue with a missing icon in IPython3
|
Needs backporting. |
|
True. I forgot that #3974 was backported |
|
How does back compatibility work with this? Is that even a sensible question to ask? My attempts to google this didn't work super well... |
|
@tacaswell Backwards compatibility should not be an issue. We already set both the FA3 (for IPython 2) and FA4 (IPython 3) icon name (see comment just above this code). I found no trace of the fact that there has ever been an icon in FA named |
FIX : Correct FA 4 name of Download icon
|
@tacaswell - think this slipped the net. It doesn't look like this got backported. Is that correct? |
|
No, this should be back ported On Mon, Feb 2, 2015, 06:25 Phil Elson notifications@github.com wrote:
|
|
Done in 293254e. |
|
Thanks, sorry for missing this one. |
|
Ha, I was about to report it wasn't working in your Binstar release @tacaswell. |
|
@tacaswell I ran through the nbagg_UAT in your Binstar version and all was well (except for the save button icon). |
|
great! |
See http://fortawesome.github.io/Font-Awesome/icon/floppy-o/
There is as far as I can see no fa-icon-save in in FA 4.x it has been renamed to fa-floppy-o
Resolves an issue with a missing icon in IPython3