Skip to content

BUG : fix security bug reported via debian by Matt Giuca #4086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 9, 2015
Merged

BUG : fix security bug reported via debian by Matt Giuca #4086

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
32d7a9f
BUG : fix security bug reported via debian by Matt Giuca
mgiuca-google Feb 9, 2015
317a05e
TST : remove test
tacaswell Feb 9, 2015
5aac964
TST : force pep8 version to be 1.5.7
tacaswell Feb 9, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ matrix:
env: BUILD_DOCS=true

install:
- pip install -q --use-mirrors nose python-dateutil numpy pep8 pyparsing pillow
- pip install -q --use-mirrors nose python-dateutil numpy pep8==1.5.7 pyparsing pillow
- sudo apt-get update && sudo apt-get -qq install inkscape libav-tools mencoder
# We use --no-install-recommends to avoid pulling in additional large latex docs that we don't need
- if [[ $BUILD_DOCS == true ]]; then sudo apt-get install -qq --no-install-recommends dvipng texlive-latex-base texlive-latex-extra texlive-fonts-recommended graphviz; fi
Expand Down
5 changes: 4 additions & 1 deletion src/mplutils.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,10 @@ Printf::Printf(const char *fmt, ...)
{
va_list ap;
va_start(ap, fmt);
vsprintf(buffer, fmt, ap);
vsnprintf(buffer, 1024, fmt, ap);
// Null-terminate the string. Non-standard C implementations (e.g.,
// Microsoft Visual C++) do not do this automatically.
buffer[1023] = '\0';
va_end(ap); // look ma - I rememberd it this time
}

Expand Down