Fixed zero args to make_compound_path. #4107
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks reasonable, but I think you want this against master, not 1.4.x, don't you? |
tacaswell
added a commit
that referenced
this pull request
Feb 17, 2015
Merged into master instead of v1.4.x Conflict was two new test in the same place, kept both.
|
Merged to master as 30f9def We can cherry-pick back to |
Had v1.4.3 not gone out of the door, no - I would have seen this hitting v1.4.3 - but as it has, it makes no difference if we target 1.4.x or not, so yes, master would be the target. |
|
Thanks for merging @tacaswell. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.