Fix3483 #4146
Fix3483 #4146
Conversation
|
Thank you for this contribution, however I am not really clear on how this address #3483. It also looks like your commit history is a bit confused. @matplotlib/developers Thoughts? I am 👎 on this on principle due to the many issues with pickles. I don't think we should provide a top-level function that implicitly endorses the usage of pickles to store or exchange figures. As part of the export functionality in MEP23 we should be able to have real serialize/deserialize functionality for the next minor point release which would supersede this. |
|
@tacaswell I think it does address #3483, by implementing a suggestion I made. The problem in #3483 is that unpickling runs into trouble in interactive mode by triggering draw() operations too soon. The solution here is to turn off interactive mode while unpickling. Apart from that, though, I agree that pickles are problematic. Given that you have grand plans for a superior serialization scheme, it is better not to introduce pickle wrappers now. |
|
@tacaswell did you really mean MEP23? |
|
No, I meant some combination of MEP25 and MEP26 On Mon, Feb 23, 2015 at 11:02 AM Federico Ariza notifications@github.com
|
|
This can be reopened if there is sufficient disagreement; but I am closing it now on the grounds that we don't want to commit to supporting a pickle-based API. I have also closed #3483. |
Fixed #3483.
Added pickle_save() function for consistency.
pickle_save() function combines pickle.dump(obj, file[, protocol]) and pickle.dumps(obj[, protocol]).
pickle_load() function combines pickle.load(file) and pickle.loads(string).
Both functions were created using a similar format to java overloading.