Skip to content

Conversation

cimarronm
Copy link
Contributor

Updated dead links for pip and pillow in the INSTALL text

@mdboom
Copy link
Member

mdboom commented Mar 9, 2015

Thanks.

On a side note -- should we try to run the sphinx linkcheck on Travis to check this kind of stuff? @jenshnielsen ?

@@ -243,7 +243,7 @@ ImageMagick
Optional dependencies
^^^^^^^^^^^^^^^^^^^^^

`Pillow <http://python-imaging.github.io/>`__
`Pillow <https://github.com/python-pillow/Pillow>`__
If Pillow is installed, matplotlib can read and write a larger
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be http://python-pillow.github.io/ which looks like the homepage rather than the git repo?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely...will update

@jenshnielsen
Copy link
Member

It would make sense to me that Travis tests links in INSTALL etc. too.

@cimarronm cimarronm force-pushed the fix_install_deadlinks branch from 4092d3b to 2f0ccaa Compare March 9, 2015 16:25
@jenshnielsen
Copy link
Member

IMHO we should not hold this back on improving Travis to catch these issues. I have opened #4205 to remind my self to do that

jenshnielsen added a commit that referenced this pull request Mar 9, 2015
@jenshnielsen jenshnielsen merged commit 01da227 into matplotlib:master Mar 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants