Skip to content

Final documentation polish for v1.1.0 release #427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 27, 2011

Conversation

WeatherGod
Copy link
Member

Just in case I am no longer able to work on the documentation any further over the next few weeks (on baby watch right now), here is my work so far.

Most of the focus is on the what's new page. There are still some ReST errors I haven't figured out (mostly with respect to referencing modules). Some of the descriptions could be expanded. Please check what I have written to make sure that I did not over-simplify some of the summaries (particularly the ipython compatibility paragraph).

Another page that might warrant updates is the API changes page: http://matplotlib.sourceforge.net/api/api_changes.html

Also, who did the tight_layout module?

Also fixed an error with stem() docs.
to the philosphy of giving users complete control over the placement of
plot elements, a :mod:`~matplotlib.tight_layout` module was created to
address the most common layout issues.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should provide one or more links to example code using the animation API

@jdh2358
Copy link
Collaborator

jdh2358 commented Aug 18, 2011

Thanks a lot for doing this -- this is a significant chunk of work that goes into each release and I'm glad you squeezed it out before the baby :-) Normally, I like to include copious links to example code as well as inline graphics in the what's new, since that is what users will be looking for. I've suggested some areas for inline links to examples, and a few choice graphics would round out this pull request.

@WeatherGod
Copy link
Member Author

Just as an additional note, in case I don't get around to it, we should also mention that this will be the last matplotlib to support python 2.4 (are we still planning to support 2.5?).

@WeatherGod
Copy link
Member Author

I added animation.py, legend.py and tight_layout.py to the API list. While they are certainly not up to the documentation standards, there are a couple of reasons to do this. First, if the module does not have an API page, then referencing it via :mod: doesn't work. Second, the animation.py documentation is completely lacking and so an API page can at least present some level of documentation, while tight_layout and legend were actually somewhat complete.

@leejjoon, I made some edits to the documentation within legend.py.

There are still some more things to do. I have to figure out how to get :mod: for mplot3d to link up, as well as create an example demonstrating the offset labels in mplot3d. The ipython information needs to be made more complete. Lastly, we have a bunch of API changes/additions to mention in the API changes page.

@jdh2358
Copy link
Collaborator

jdh2358 commented Aug 21, 2011

On which python to support after 1.1, perhaps we should support python2.7 and later to ease the integration of the python3 branch.

@WeatherGod
Copy link
Member Author

2.7 is kind of a big jump. My rule of thumb is to use whichever version RHEL is using (which is 2.5 right now). Now, who knows what RHEL will be supporting by the time we do our next release, so it might not be that bad. Therefore, if we were to target 2.7 next, then I think we need to promise LTS for v1.1.

@mdboom
Copy link
Member

mdboom commented Aug 22, 2011

Python 2.6 or later is sufficient to support 3.x. However 2.5 is just too difficult to support in conjunction with 3.x -- that is what is holding us back from merging the py3 branch. I think we can support bugfixes on a 1.1.x branch for some time even as master drops Python 2.5 compatibility, though.

@WeatherGod
Copy link
Member Author

Python 2.6 might be a good compromise. That version does allow for the new exception syntax, 'with' clauses, ternary statements, new string formatting, and class decorators (which might be very useful).

efiring added a commit that referenced this pull request Aug 27, 2011
Final documentation polish for v1.1.0 release
@efiring efiring merged commit 1d8b6fb into matplotlib:master Aug 27, 2011
@butterw
Copy link

butterw commented Aug 28, 2011

Could you please add the following to "other enhancements" (mpl 1.1.0) in doc/users/whats_new.rst ?

  • Peter Butterworth added named figure support to :func:~matplotlib.pyplot.figure

@efiring
Copy link
Member

efiring commented Aug 29, 2011

It's in a new branch I'm working on after committing Ben's branch.

@leejjoon
Copy link
Contributor

Building docs fails on me.

The "what's new" page refers "mpl_examples/mplot3d/offset_demo.py" but this does not seems to be version controlled.

@WeatherGod
Copy link
Member Author

My bad... I forgot to add that file to my commit. How do we want to fix this?

@efiring
Copy link
Member

efiring commented Aug 29, 2011

On 08/28/2011 07:35 PM, WeatherGod wrote:

My bad... I forgot to add that file to my commit. How do we want to fix this?

I suggest you just go ahead and commit it directly; no need for a
separate pull request. (update your master from upstream, add the file,
commit it, and push back to upstream master.)

@WeatherGod
Copy link
Member Author

Done!

mdboom added a commit that referenced this pull request Aug 30, 2011
documentation follow-up to #427, moving towards v1.1 release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants