fix rcParams legend.facecolor and edgecolor never being used #4362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…end..."], but never being used in the call to FancyBboxPatch
|
Good catch! That is my bad. |
|
Would be good to have a test for this i guess? |
|
Yeah, the PR that got merged was my proportional for how to fix this and I was waiting for Eric to agree it was reasonable before I added tests. |
tacaswell
added a commit
that referenced
this pull request
Apr 21, 2015
FIX : rcParams legend.facecolor and edgecolor never being used cleans up #4193
|
I have added an issue and self assigned to take care of cleaning up the tests/documentation for this. @jclevesque Thanks for the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They were correctly read from rcParams, but ignored after that. See the old code :
if rcParams["legend.facecolor"] == 'inherit': facecolor = rcParams["axes.facecolor"] else: facecolor = rcParams["legend.facecolor"] if rcParams["legend.edgecolor"] == 'inherit': edgecolor = rcParams["axes.edgecolor"] else: edgecolor = rcParams["legend.edgecolor"] self.legendPatch = FancyBboxPatch( xy=(0.0, 0.0), width=1., height=1., facecolor=rcParams["axes.facecolor"], edgecolor=rcParams["axes.edgecolor"], mutation_scale=self._fontsize, snap=True )