FIX : fix mis-matched new/delete in CXX #4431
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem here is that the constructor for ExtensionClassMethodsTable() is allocating an array of m_methods_table, so it should be deallocated with delete[].
tacaswell
added a commit
that referenced
this pull request
May 15, 2015
FIX : fix mis-matched new/delete in CXX
|
Self merged as this is @dnovillo 's patch. |
|
color_overhaul is still using CXX? |
|
Yeah, 2.1 will be the first feature release without CXX |
|
PyCXX was removed in 1.5.0 and this branch was never used for anything, so this PR is not in use. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem here is that the constructor for
ExtensionClassMethodsTable() is allocating an array of m_methods_table,
so it should be deallocated with delete[].