Rasterize colorbar when it has many colors; closes #4480 #4481
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Travis failures are unrelated. |
|
How about making the threshold a public attribute of |
|
Yes, I know... It sounds like you are talking about making it a class attribute for now, in anticipation of all instance configuration variables ending up declared at the class level as Configurables or some such. Correct? |
|
I was thinking as an instance level attribute, but class level makes more sense. |
|
@tacaswell If this looks OK, I can add a what's new entry. @WeatherGod, comments? |
|
👍 from me. |
219e13f to
241b3fc
Compare
WeatherGod
added a commit
that referenced
this pull request
Jun 8, 2015
Rasterize colorbar when it has many colors; closes #4480
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is the simplest possible way to reduce the number of complaints about the appearance of the colorbar as rendered from vector files. It could be made more complicated by using an rcParam for the threshold, and/or by adding a kwarg, but I'm not convinced that either of these would be worthwhile.