imread with URL string unit test #4485
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These modifications allow valid URL strings to be passed directly into imread. URL recognition is done using the standard library function urlparse. If the string contains a valid url scheme, it will be used to download and process the data using a combination of urlopen and BytesIO (StringIO in python 2).
The Pillow docs state that Image.open can handle either a filename string or a file object. That simplifies the pilread function substantially.
It seems that the identity test for the parsed URL scheme was not sufficient. I changed this to an equality test, and things are now working properly.
Also added the logo2.png file to the test image folder. If there is a URLError, imread will simply open the local file and print a little error.
|
@tacaswell I tried to add the test case as a new branch at the end of my original PR. But now it looks like this brought in all of the commits from my other branch as well. I hope this is okay. If not, could you provide some guidance on how to fix this. |
|
Just leave it, github is very clever and this will look better once the other PR is merged. |
|
Anything holding up this PR? |
|
The hold up on this is ensuring that adding a test that touches the internet is kosher with debian packaging rules. |
|
Could we perhaps use |
|
Replaced by #10817. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a test case to #4256. At this point, it may need some careful thought because it pulls an image down from the internet. This may be a violation of Debian's packaging rules. See #4256 for more discussion.