Raise more useful error when tfm file is missing #4521
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -396,6 +396,8 @@ def _xxx(self, special): | |||
|
|
|||
| def _fnt_def(self, k, c, s, d, a, l, n): | |||
| tfm = _tfmfile(n[-l:].decode('ascii')) | |||
| if tfm is None: | |||
| raise FileNotFoundError("missing font metrics file: %s" % tfm) | |||
There was a problem hiding this comment.
Won't this print out None for the file name?
There was a problem hiding this comment.
On 14 Jun 2015, at 21:02, Thomas A Caswell notifications@github.com wrote:
In lib/matplotlib/dviread.py #4521 (comment):
@@ -396,6 +396,8 @@ def _xxx(self, special):
def _fnt_def(self, k, c, s, d, a, l, n): tfm = _tfmfile(n[-l:].decode('ascii'))
if tfm is None:raise FileNotFoundError("missing font metrics file: %s" % tfm)—
Reply to this email directly or view it on GitHub https://github.com/matplotlib/matplotlib/pull/4521/files#r32382377.You’re right; fixed.
tacaswell
added a commit
that referenced
this pull request
Jun 14, 2015
ENH: Raise more useful error when tfm file is missing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4475