A few WX phoenix related changes #4554
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jenshnielsen
commented
Jun 24, 2015
- Two additional methods have changed name in WX Phoenix. We should probably do consider doing this in a more elegant way but for now these are the minimal changes to make zoom work probably.
- Don't depend on wxversion in setupext. It's no longer a dependency of the wx backend so neither should it be here.
We don't need it in the backend anymore so might as well make it optional here too
|
attn: @wernerfb |
|
Just adding myself and @fariza to the list of participants as we need to follow this for MEP22. |
| @@ -1713,14 +1713,20 @@ def draw_rubberband(self, event, x0, y0, x1, y1): | |||
| rubberBandColor = '#C0C0FF' # or load from config? | |||
|
|
|||
| # Set a pen for the border | |||
| color = wx.NamedColour(rubberBandColor) | |||
| if wxc.is_phoenix: | |||
| color = wx.Colour(rubberBandColor) | |||
There was a problem hiding this comment.
NamedColour is defined in wx_compat, so you could just use wxc.NamedColour(rubberBandColor)
DrawRectangleRect has been renamed to DrawRectange. So we monkeypatch the new version to add the old version as an alias
WeatherGod
added a commit
that referenced
this pull request
Jun 26, 2015
A few WX phoenix related changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.