-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Add Seaborn style sheets; addresses #4566 #4570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for doing this. |
I was thinking of calling this one simply |
Attn @mwaskom: comments? |
I would prefer the current default seaborn style to be called Do matplotlib stylesheets have any facility for handling style and element scale ("context" in seaborn, regrettably) independently? |
There is MEP26 that is being ironed out, if that is what you are thinking? On Tue, Jun 30, 2015 at 3:59 PM, Michael Waskom notifications@github.com
|
I just mean that the "seaborn styles" are really the product of two independent sets of rc parameters. |
The scaling and colors could be split into two different stylesheets, which would allow users to
|
Actually good point, you also need a third piece: the color cycle palette. |
Would it be worth adopting the scale style sheets wholesale so
? The color cycle might be complicated / should embrace #4258 (which needs to be replaced by a PR to add https://github.com/tacaswell/cycler (which needs to end up on pypi and move to the mpl org) ). |
I don't think seaborn does anything as complicated as your cycler tool, it just sets the color cycle independently from the axes style and plotting context. |
Right, leave cycler out of this. @petebachant Can you split the style sheet up as discussed (base axes settings, font/tick sizes, color cycle)? There is a PR in to use styles in styles (#4240 ) which can be used to create composite style sheets if we want that as well. |
Sure, I will split the style sheets up. |
Just split the darkgrid style into three sheets for the scaling, colors, and palette. What do you guys think? Should I make the other Seaborn variants? |
👍 to both this and the other variants. |
@petebachant I am going to merge this as-is, can you make a new PR with the other variants ? |
ENH: Add Seaborn style sheets closes #4566
Will do! |
This commit adds the default Seaborn "darkgrid" style to the style library.