-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
[WIP] Property Cycling #4686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
[WIP] Property Cycling #4686
Changes from all commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
d08c627
Add Cycler as a dependency
WeatherGod e3c0951
Implemented style cycling using cycler.
WeatherGod 160401b
Fix a typo for cycler dependency
WeatherGod 6b2223d
Initial implementation of property cycling
WeatherGod 0c1e609
Fix some typos and handle some other codes using color cycling
WeatherGod 61d10f9
Make dict access safer
WeatherGod e356972
Added some tests for baseline features
WeatherGod 68f0afb
Updated the fill test to get the hatching.
WeatherGod c806726
fix typo
WeatherGod 9965f5f
should have linted
WeatherGod 5fa07f2
Getting cycling to work!
WeatherGod 98fb775
Add deprecation notice for axes.color_cycle
WeatherGod f443629
Some axes.prop_cycler param improvements.
WeatherGod 648d3ea
Made the linewidth thicker for a test
WeatherGod 2e7b6a5
Updated styles and templates for prop_cycle
WeatherGod a1b822f
Some documentation and updating an old example
WeatherGod 6df7829
PEP8 fixes
WeatherGod 871d616
Simplify set/getdefaults logic for property cycler
WeatherGod e7786d0
Added basic validation/normalization for cycler
WeatherGod 153ef67
* aliases support
WeatherGod 8ce4797
Support and test for marker cycling
WeatherGod f3e8394
* Fix cycler advance bug (and added test)
WeatherGod 6b5a6a5
Added the deprecation notice to api_changes/
WeatherGod c72a74f
PEP8 fixes
WeatherGod 53f1ff2
Fix test now that we normalize property names
WeatherGod 9a31950
some simplification and doc-fixes
WeatherGod 55bf053
Fix a typo
WeatherGod 44f74e3
Finalized the validating cycler design.
WeatherGod 5a3ce17
reduce() isn't built-in in py3k. go figure...
WeatherGod 9848661
Improve set_prop_cycle(). Docstring fixes.
WeatherGod 63d6321
Realized that I didn't have a hatch validator
WeatherGod File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
`color_cycle` deprecated | ||
```````````````````````` | ||
|
||
In light of the new property cycling feature, | ||
the Axes method *set_color_cycle* is now deprecated. | ||
Calling this method will replace the current property cycle with | ||
one that cycles just the given colors. | ||
|
||
Similarly, the rc parameter *axes.color_cycle* is also deprecated in | ||
lieu of the new *axes.prop_cycle* parameter. Having both parameters in | ||
the same rc file is not recommended as the result cannot be | ||
predicted. For compatibility, setting *axes.color_cycle* will | ||
replace the cycler in *axes.prop_cycle* with a color cycle. | ||
Accessing *axes.color_cycle* will return just the color portion | ||
of the property cycle, if it exists. | ||
|
||
Timeline for removal has not been set. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Under what condition willplot
returnNone
?!?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Never mind, I understand this logic now.