Lock mock down to a version that we know works #4692
Closed
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I merged #4687 which I think is a better forward looking solution to this problem, closing this as the problem is fixed. |
|
So do I, this was intended as a quick risk free alternative |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simpler alternative to #4687 to get master back to passing. Installing new versions of mock as happens on python 2.7 and the pep8 tests don't work well with the current version of setuptools on Travis. This gets around it by explicitly installing the old mock version in all python 2 envs.
I would appreciate if someone could merge either this #4687 asap to get the master branch back to parsing.