Travis: Set exit to true in nose.main #4708
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise the exit status is not set correctly and travis does not fail
3e24616 to
5693e3f
Compare
|
@matplotlib/developers Please be careful when merging PR's until this is fixed. The Travis status will be set to passed incorrectly. Im sorry that I did not notice before |
tacaswell
added a commit
that referenced
this pull request
Jul 16, 2015
Travis: Set exit to true in nose.main
|
3.5 fails, so this looks good 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the merge of #4668 tests do not fail correctly on Travis. This sets exit to True in nose.main. Otherwise the exit status is not set correctly and Travis does not fail on failure.
Compare https://travis-ci.org/matplotlib/matplotlib/jobs/71108096 which should have failed but does not to the result of the python 3.5 job on this branch