Skip to content

Backport #4335 to master #4733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 22, 2015
Merged

Backport #4335 to master #4733

merged 1 commit into from
Jul 22, 2015

Conversation

mdboom
Copy link
Member

@mdboom mdboom commented Jul 17, 2015

Done as a pull request to give it some Travis testing first.

@tacaswell tacaswell added this to the Color overhaul milestone Jul 17, 2015
@tacaswell
Copy link
Member

I am now confused if we want to put this in for 1.5 or 2.0

@mdboom
Copy link
Member Author

mdboom commented Jul 17, 2015

Well, I guess strictly speaking it's an API / behavior change. It's already on color_overhaul. Let me know where else you think it should go.

@WeatherGod
Copy link
Member

If it is on color overhaul, then it should be on 1.5. There should be
little, if any, code difference between 1.5 and 2.0.
On Jul 17, 2015 9:40 AM, "Michael Droettboom" notifications@github.com
wrote:

Well, I guess strictly speaking it's an API / behavior change. It's
already on color_overhaul. Let me know where else you think it should go.


Reply to this email directly or view it on GitHub
#4733 (comment)
.

@jenshnielsen
Copy link
Member

Im 👍 on getting it into 1.5 for the same reasons as @WeatherGod

@tacaswell
Copy link
Member

Going with this is a bug fix and merging in for 1.5

tacaswell added a commit that referenced this pull request Jul 22, 2015
@tacaswell tacaswell merged commit 66dd16f into matplotlib:master Jul 22, 2015
@tacaswell tacaswell modified the milestones: Color overhaul, next major release (2.0) Oct 26, 2015
@mdboom mdboom deleted the 4335-backport branch November 10, 2015 02:38
@QuLogic QuLogic modified the milestones: v1.5.0, 2.0 (style change major release) Oct 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants