Test nearest and none interpolation better #476
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes the baseline file image_interps.pdf to match the current behavior of the code, and adds a new test for the difference between "nearest" and "none" interpolation.
…sn't like images with negative dimensions, so change to positive and adjust the offset accordingly.
|
I submitted a pull request to your branch that addresses the SVG issue. Inkscape does not seem to like images declared with negative dimensions, so I flipped the "height" dimension and adjusted the transform accordingly. |
Fixes the SVG issues with "none" interpolation
|
Thanks, merged the fix. |
jkseppan
added a commit
that referenced
this pull request
Sep 23, 2011
Test nearest and none interpolation better
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the baseline file image_interps.pdf to match the current
behavior of the code, and adds a new test for the difference between
"nearest" and "none" interpolation.
Fixes the problem reported at http://thread.gmane.org/gmane.comp.python.matplotlib.devel/10543
Request: I would like someone who works with the svg backend to check if the added test makes sense for svg and if the output looks good. It did look odd to me in Inkscape, but that might be an old version or misconfiguration. The idea of the test is that interpolation="none" should produce pixels of the same size, but interpolation="nearest" produces different-sized pixels with a suitable dpi setting.