Skip to content

Conversation

OceanWolf
Copy link
Member

No description provided.

@OceanWolf OceanWolf added the MEP: MEP27 decouple pyplot from backends label Jul 27, 2015
@tacaswell
Copy link
Member

attn @pwuertz

@pwuertz
Copy link
Contributor

pwuertz commented Jul 27, 2015

I guess it's my personal preference to explicitly implement subclass constructors just in case, but no objections if you prefer to have it removed.

@OceanWolf
Copy link
Member Author

Looking at the other non-gui backends, none of them have their own constructor. I guess I go for extra stuff to maintain.

Here for example it only accepts and passes _args and not *_kwargs to the parent class (something I need for MEP27). As this constructor doesn't actually do anything I thought it easier to just remove the whole thing, than add **kwargs, but I don't really mind, but we should stay consistent with the other backends

@pwuertz
Copy link
Contributor

pwuertz commented Jul 27, 2015

Right, its easier to maintain in case you want to add something to the base class. No objections.

tacaswell added a commit that referenced this pull request Jul 27, 2015
@tacaswell tacaswell merged commit ed44362 into matplotlib:master Jul 27, 2015
@OceanWolf OceanWolf deleted the pgf-cleanup branch July 27, 2015 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MEP: MEP27 decouple pyplot from backends
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants