Skip to content

mep12 on mri_demo.py #4869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

mep12 on mri_demo.py #4869

wants to merge 2 commits into from

Conversation

ericmjl
Copy link
Contributor

@ericmjl ericmjl commented Aug 5, 2015

No description provided.

@dopplershift dopplershift added the MEP: MEP12 gallery and examples improvements label Aug 5, 2015
@pelson
Copy link
Member

pelson commented Aug 5, 2015

I confess, I've merged #4868, but just noticed the folder that this example is in. I wonder if we need to rename the directory, or whether that will just make the location inconsistent for users between mpl versions...

@ericmjl
Copy link
Contributor Author

ericmjl commented Aug 5, 2015

For now, I have stuck with only changing formatting, and ignored changing the directories of the pylab_examples. I think the decision as to which directory to put the example in should be discussed together, for each example, rather than decided by me :).

@ericmjl
Copy link
Contributor Author

ericmjl commented Aug 5, 2015

Btw, what's the failure point in this case? It doesn't look like my usual pep8 failures.

@pelson
Copy link
Member

pelson commented Aug 5, 2015

Hmmm. I've not seen that before - I've restarted it to see if it is stochastic.

@jenshnielsen
Copy link
Member

@pelson It's my hope that we can basically empty the pylab_examples folder by moving most examples to topic specific folders. I talket to @tacaswell at Scipy avout the fact that if we want users discouraged from using pylab then at least we shouldn't have any that many examples using pylab so IMHO this is a step in the right direction.

@jenshnielsen
Copy link
Member

@ericmjl I merged this via #4871 to avoid the merge commit at the bottom (It still shows up as your commit)

@ericmjl ericmjl deleted the mri_demo.py_mep12 branch August 6, 2015 15:44
@QuLogic QuLogic added this to the v1.5.0 milestone Nov 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MEP: MEP12 gallery and examples improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants