Reduce redudant code in axes_grid{,1}.colorbar #4890
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove redudant code by using axes_grid1's implementation
|
For the record also changes 2 docstrings. |
tacaswell
added a commit
that referenced
this pull request
Aug 12, 2015
MNT: Reduce redudant code in axes_grid{,1}.colorbar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
mpl_toolkits.axes_gridwas made into, essentially, a wrapper formpl_toolkits.axes_grid1, thempl_toolkits.axes_grid.colorbarwas copied instead of moved. Today, this results inmpl_toolkits.axes_grid.colorbarandmpl_toolkits.axes_grid1.colorbarbeing identical except for a few lines.This PR fixes that. The only practical change is to apply PR #630 to
axes_grid's version of colorbar.