Skip to content

DOC: MEP to improve the Axes API #5029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from

Conversation

OceanWolf
Copy link
Member

A beginning of an MEP to start discussion...
As well as providing a more streamlined and logical API, this MEP will close the following bugs:


First we define our coordinate transformation functions:
axes_to_base(self, \*q)
base_to_axes(self, x, y)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These live in the transform in existing matplotlib speak. It might be worth mentioning this (or even providing a section on what the transform currently does).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, I will do that! In terms of these specific lines in the MEP, I kind of knew that we did these by transforms, but it becomes really unclear (especially for the novice user, and in terms of the Axes API, I still consider myself one of them) which does what, so many transforms ;)... so here I thought having a clear self-explaining API would help here.

@pelson
Copy link
Member

pelson commented Sep 8, 2015

Nice start @OceanWolf. Obviously this is not complete, so I encourage you to continue iterating, and to ping us when you are ready for some substantial comment.

👍

@OceanWolf
Copy link
Member Author

Thanks @pelson, yes, I will continue iterating on this. As I say in my reply above. while I now have a lot of knowledge in the backends, I still feel very new to the Axes "logic". It feels like a maze (well more of a jungle) of callbacks and aliases to functions and weird function names that don't do what they say they do... and that happens before you get to the transform stack/swamp which recurses (verb of recursion?) many layers deep. Luckily one can mostly avoid having to go near that swamp, but if one has too, like I had to to debug #4318, eeek.

But yes, now I have an idea of a few things to look at in this jungle, I can expand a lot more on this MEP :).

@OceanWolf OceanWolf mentioned this pull request Sep 16, 2015
@tacaswell tacaswell added this to the next major release (2.0) milestone Oct 8, 2015
@tacaswell tacaswell modified the milestones: 3.0 (future), 2.0 (style change major release) Jan 25, 2016
@tacaswell tacaswell modified the milestones: v3.0, v3.1 Jul 7, 2018
@jklymak jklymak modified the milestones: v3.1.0, unassigned Feb 7, 2019
@dstansby dstansby removed the ongoing label Jun 1, 2019
@jklymak
Copy link
Member

jklymak commented Jul 14, 2020

...closing as stale..

@jklymak jklymak closed this Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants