Skip to content

Added PDF version of navigation icons #5044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 12, 2015

Conversation

astrofrog
Copy link
Contributor

This adds PDF versions of the navigation icons, as requested by @mdehoon in #4978, since it will allow us to use HiDPI icons in the MacOS X backend (and maybe others)

Note: I also created a new icon for the subplots icon since the SVG was missing for the original icon. I tried to make it look similar to before:

screen shot 2015-09-10 at 13 47 43

@astrofrog
Copy link
Contributor Author

I'm confused about the Python 3.5 failure - is this related to this PR?

@jenshnielsen
Copy link
Member

It's most likely one of our random transient failures. I have restarted that job

@astrofrog
Copy link
Contributor Author

@jenshnielsen - thanks!

@mdehoon
Copy link
Contributor

mdehoon commented Sep 11, 2015

I can confirm that these PDF files work with the MacOSX backend.

Low resolution:
screengrab lowres

High resolution:
screengrab highres

@WeatherGod
Copy link
Member

yay! I also like the redone icon for the subplot editor. Much neater than
before!

On Fri, Sep 11, 2015 at 12:48 PM, mdehoon notifications@github.com wrote:

I can confirm that these PDF files work with the MacOSX backend.

Low resolution:
[image: screengrab lowres]
https://cloud.githubusercontent.com/assets/136062/9820647/356da082-58f0-11e5-919b-889f28485bc9.png

High resolution:
[image: screengrab highres]
https://cloud.githubusercontent.com/assets/136062/9820656/4051c622-58f0-11e5-938c-b1097dc543aa.png


Reply to this email directly or view it on GitHub
#5044 (comment)
.

@tacaswell
Copy link
Member

as a side note, these pdfs are smaller than most of our source files.

tacaswell added a commit that referenced this pull request Sep 12, 2015
ENH: Added PDF version of navigation icons
@tacaswell tacaswell merged commit 484c0f2 into matplotlib:master Sep 12, 2015
@tacaswell
Copy link
Member

@astrofrog Thanks! I also really like the new sub-plot icon.

@astrofrog
Copy link
Contributor Author

@tacaswell - thanks for merging!

@mdehoon - will you open a pull request with the changes needed to switch the MacOS X backend to using these?

@mdehoon
Copy link
Contributor

mdehoon commented Sep 14, 2015

@astrofrog See #5062 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants