Bugfix for TriAnalyzer mismatched indexes #5065
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bugfix for issue #4999.
It follows a tightening up in numpy 1.10 when indexing one array with a second boolean array which is smaller, such as
Here
index_array
is shorter thanx
. Prior to numpy 1.10 this was acceptable, withindex_array
padded out withFalse
values. In numpy 1.10 it issues aVisibleDeprecationWarning
.The problem occurs in
TriAnalyzer
for aTriangulation
that contains points that are not referenced by any triangles, which can occur if triangles are masked out. The solution is to make sure the boolean array is of the correct size, which is easily accomplished in this case using theminlength
kwarg which was added tonumpy.bincount
in version 1.6.I have not added an explicit test as the existing
test_triangulation.test_tritools
already finds the bug.Thanks to @WeatherGod for reporting the problem.