Skip to content

Proposed change to default log scale tick formatting #5161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Aug 22, 2016
Merged

Proposed change to default log scale tick formatting #5161

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
1320261
add LogFormatterSciNotation
zblz Oct 1, 2015
56e2871
manage locators not deriving from LocatorBase
zblz Oct 9, 2015
a6e954d
generalize label location for all bases
zblz Oct 15, 2015
4ce70e9
use _mathdefault in non-usetex mathtext
zblz Jan 22, 2016
d1a5aff
add tests
zblz Jul 24, 2016
4e83e9a
move labeling logic into LogFormatter
zblz Aug 2, 2016
ad0a751
fix numdec computation for symlog axes
zblz Aug 3, 2016
f04bff0
update baseline images for log_scales test
zblz Aug 3, 2016
5c28e95
do not fail on _DummyAxes
zblz Aug 3, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions lib/matplotlib/scale.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

from matplotlib.cbook import dedent
from matplotlib.ticker import (NullFormatter, ScalarFormatter,
LogFormatterMathtext, LogitFormatter)
LogFormatterSciNotation, LogitFormatter)
from matplotlib.ticker import (NullLocator, LogLocator, AutoLocator,
SymmetricalLogLocator, LogitLocator)
from matplotlib.transforms import Transform, IdentityTransform
Expand Down Expand Up @@ -304,9 +304,9 @@ def set_default_locators_and_formatters(self, axis):
log scaling.
"""
axis.set_major_locator(LogLocator(self.base))
axis.set_major_formatter(LogFormatterMathtext(self.base))
axis.set_major_formatter(LogFormatterSciNotation(self.base))
axis.set_minor_locator(LogLocator(self.base, self.subs))
axis.set_minor_formatter(NullFormatter())
axis.set_minor_formatter(LogFormatterSciNotation(self.base))

def get_transform(self):
"""
Expand Down Expand Up @@ -462,7 +462,7 @@ def set_default_locators_and_formatters(self, axis):
symmetrical log scaling.
"""
axis.set_major_locator(SymmetricalLogLocator(self.get_transform()))
axis.set_major_formatter(LogFormatterMathtext(self.base))
axis.set_major_formatter(LogFormatterSciNotation(self.base))
axis.set_minor_locator(SymmetricalLogLocator(self.get_transform(),
self.subs))
axis.set_minor_formatter(NullFormatter())
Expand Down
Binary file modified lib/matplotlib/tests/baseline_images/test_axes/log_scales.pdf
View file
Open in desktop
Binary file not shown.
Binary file modified lib/matplotlib/tests/baseline_images/test_axes/log_scales.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading