-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Matlab Style Label Warns In Test #5244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Matlab Style Label Warns In Test #5244
Conversation
b96cbcf
to
20287be
Compare
20287be
to
263c06a
Compare
@JanSchulz Was that intentional? |
I've no idea what this is about :-( @rmorshea: What are the concrete error messages? |
So no 😉 The issue is that the |
TST: suppress warnings in test suite
TST: suppress warnings in test suite
backported as 2d9aa73 |
Should we open a new issue about this "bug"? (I'd just do it, but I haven't been following the labeling work very closely...) It seems that this ambiguity is a problem. Though it could probably be resolved by assuming 'y' is a label if it's preceded by other labels or is the first argument. That's a horrible heuristic hack, but we are in fact shoehorning two vastly different APIs (matlab-like and pandas-like) together here. There's bound to be rough edges... |
There was a long discussion of this in the PR where the labeled data went in. The heuristic is if it is a column, it gets used, but if it could have been a style spec string the user gets a warning. The winning logic for defaulting to de-referencing the column is that you can get the same style effect, just more verbosely using kwargs. |
It seems pretty weird that one would be warned for using the labels "x" and "y" since it's so common as to be nearly universal. Would it be unreasonable to require that the first two arguments be labels? |
Requiring the first two arguments to be labels unfortunately would be a major break in behavior. See However, I think it is reasonable that if the first argument is a string, then it is a label and so are all other single strings prior to the kwargs. It's an icky heuristic, but I think it might be better than this warning which, as you say, is for a very common case. |
I forgot that |
Was receiving warnings on master due to ambiguous matlab style data labeling (use "i" and "j" instead).