Added check for empty bboxes in count_bboxes_overlapping_bbox #5245
Conversation
…empty (any dimension has size 0)
| @@ -752,6 +752,10 @@ int count_bboxes_overlapping_bbox(agg::rect_d &a, BBoxArray &bboxes) | |||
| agg::rect_d b; | |||
| int count = 0; | |||
|
|
|||
| // If bboxes is empty return zero | |||
| if (bboxes.dim(0) == 0 || bboxes.dim(1) == 0 || bboxes.dim(2) == 0) | |||
There was a problem hiding this comment.
Maybe say: bboxes.dim(1) != 2 || bboxes.dim(2) != 2? We are bound to have other issues if its mishapen in some other way. Though having a zero anywhere in the shape doesn't indicate a bug elsewhere, having anything other than 2 in the final two dimensions does, so maybe we need to turn that case into an exception.
|
I'm not opposed to this, and it does fix the bug. However, I'd still like to find something that plugs this hole everywhere, not just in one place. That may mean just grepping for all uses of |
|
@mdboom, that makes sense to me. Maybe I'll let you tackle that and we hold off on this PR in favor of a more general fix. |
Another proposed fix for issue #5185