Check dimensions of arrays passed to C++, handle 0 dimensions #5274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check the dimensions on arrays passed to C++ to ensure they are what we expect.
|
👍 |
| @@ -358,7 +358,7 @@ void get_path_collection_extents(agg::trans_affine &master_transform, | |||
| agg::trans_affine &offset_trans, | |||
| extent_limits &extent) | |||
| { | |||
| if (offsets.dim(0) != 0 && offsets.dim(1) != 2) { | |||
| if (offsets.size() != 0 && offsets.dim(1) != 2) { | |||
There was a problem hiding this comment.
I'm not sure if this needed changing, but it doesn't hurt aside from a vague feeling of asymmetry.
|
👍 Should there be a note in the documentation recommending the use of |
This was referenced Oct 19, 2015
|
I've added a comment about size(). We don't really have formal documentation about our internal C++ APIs outside of header comments. |
mdboom
added a commit
that referenced
this pull request
Oct 19, 2015
Check dimensions of arrays passed to C++, handle 0 dimensions
mdboom
added a commit
that referenced
this pull request
Oct 19, 2015
Check dimensions of arrays passed to C++, handle 0 dimensions
|
Backported to 1.5.x as f529327 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a combination of #5264 and #5246 that doesn't require #5241, and thus should be more robust to unusual arrays that Numpy creates with 0 dimensions in the middle somewhere.
Fixes #5185