-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Reduce dupe between tests.py and matplotlib.test #5330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce dupe between tests.py and matplotlib.test #5330
Conversation
0b69a58
to
4a9d870
Compare
@@ -64,21 +64,14 @@ install: | |||
pip install --upgrade setuptools | |||
# Install only from travis wheelhouse | |||
- if [ -z "$PRE" ]; then | |||
wheelhouse_pip_install python-dateutil $NUMPY $PANDAS pyparsing pillow sphinx!=1.3.0; | |||
wheelhouse_pip_install python-dateutil $NUMPY $PANDAS pyparsing pillow sphinx!=1.3.0 mock; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mock
shouldn't be necessary on Python 3, unless we're using something really new from 3.5.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
However, it appears all imports prefer the Python 3 location, so this should be harmless.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah -- I thought it simplest to just always do it.
#5338 builds the docs on Python 3.5 |
pep8 is also run on 2.7. That one seems safe to just flip to 3.5 now as well. |
606ccb9
to
f9e7255
Compare
f9e7255
to
a4715f9
Compare
TST: Reduce dupe between tests.py and matplotlib.test
…tion TST: Reduce dupe between tests.py and matplotlib.test Conflicts: .travis.yml
Backported to v2.x via f9cb9cf. |
Fix #5328