Fix Cairo memleak #5372
Merged
Fix Cairo memleak #5372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The input buffer is copied internally when PyByteArray_FromStringAndSize is called, so it doesn't need to stay around.
|
Looks correct to me, since |
|
👍 Thanks. (The values reported by the script in #5360 aren't very reliable and are certainly of the wrong scale, but this is a legit memory leak nonetheless). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to #5360, you can see a small memleak with the Cairo backend, apparently only 26.4889 bytes/loop. After fixing the leak, it's -0.7111 bytes/loop (aka 0).