Qt4agg draw #539
Merged
Qt4agg draw #539
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the latest in a series of modifications to the Qt4Agg drawing strategy going back several years. It simplifies the code and should solve the problem introduced in 6938b00; that is, delaying the Agg draw operation until the paintEvent breaks code expecting that draw operation to have occurred immediately. The problem was reported here: http://sourceforge.net/mailarchive/message.php?msg_id=28245744
|
@efiring: It would be great to merge this -- is there a way you can suggest I test this? |
|
The email that pointed out the problem did not include a test case, and I don't have one, other than exercising the qt4 backend in normal use. The problem and solution seem pretty simple, though; my inclination would be to merge, and see how it fares out in the world. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the latest in a series of modifications to the Qt4Agg
drawing strategy going back several years. It simplifies the
code and should solve the problem introduced in 6938b00; that
is, delaying the Agg draw operation until the paintEvent breaks
code expecting the draw operation to have occurred immediately.
The problem was reported here:
http://sourceforge.net/mailarchive/message.php?msg_id=28245744