Only call init function at the begining of a save when user supplied #5402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a user supplied function is given it is probably needed to restart the animation. The default just inserts the first frame and restarts the animation which is not useful. Fixes matplotlib#5399
|
Awesome. I like it. |
|
Sorry about punting the issue, I wasn't exactly sure how |
|
@cbreeden Can you confirm that this fixes your issue? |
|
@tacaswell yes. It fixes the issue described in #5399. |
tacaswell
added a commit
that referenced
this pull request
Nov 4, 2015
FIX: Only call init function at the begining of a save when user supplied
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a user supplied function is given it is probably needed to restart the animation. The default just inserts the first frame and restarts the animation which is not useful. Fixes #5399