Remove uses of font.get_charmap #5410
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,8 +1,6 @@ | |||
| """ | |||
| font data tables for truetype and afm computer modern fonts | |||
| """ | |||
| # this dict maps symbol names to fontnames, glyphindex. To get the | |||
| # glyph index from the character code, you have to use get_charmap | |||
There was a problem hiding this comment.
This comment is out of date and should have been removed in #5299.
|
looks good to me. Is this intended to be backported anywhere? |
|
also, is there any plan to mark |
Yes, to 2.0 which can benefit from this for the larger fonts.
Longer term (probably 2.1, though I'm not promising that as a dealine), this will all be replaced by matplotlib/freetypy. See my freetypy branch. |
tacaswell
added a commit
that referenced
this pull request
Nov 5, 2015
MNT: Remove uses of font.get_charmap
|
This does not backport cleanly, I will have a PR soon |
tacaswell
added a commit
to tacaswell/matplotlib
that referenced
this pull request
Nov 5, 2015
MNT: Remove uses of font.get_charmap
Conflicts:
lib/matplotlib/tests/test_font_manager.py
Conflicts with merging the tests, resloved to add only relavent code.
WeatherGod
added a commit
that referenced
this pull request
Nov 5, 2015
Merge pull request #5410 from mdboom/get-charmap-removal
|
Backported via #5412. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-on to #5299 and removes all other uses of
FT2Font.get_charmapin the code base (and these ones were a lot easier). Again, this helps a lot with large Unicode fonts since we don't have to generate a large dictionary just to access the handful of characters any one plot contains.