-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Properly handle transparency for animations #5415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
30c2a09
Add 'flatten' kwarg to backend_agg savefig for print_png and print_ra…
cbreeden b8175a1
Fix width/height locations, and forgot to add alpha layer to flatten_…
cbreeden 2fa1889
Move flatten_rgba to image.py and implment flatten_rgba for jpeg files.
cbreeden e0f1fd8
Removed typo
cbreeden d5fbd89
Clarify comment
cbreeden a57be1f
Appease the PEP8 gods. Somewhat of a sacraficial lamb if you ask me.
cbreeden 0193d55
Add tests for flatten kwarg
cbreeden b2c4560
Fix typo in tests
cbreeden File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confusingly, the (w, h) I think is correct here because this is for PIL, not Numpy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I think the images looked correct even though I decoded the stream as a (w,h) Numpy array because the pixels were still being matched correctly for flattening. Why does matplotlib use HxW for serializing its images? Isn't WxH a commonly accepted standard?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The images are in row-major order (i.e. as English text is read), and Numpy dimensions are in the order of "slowest moving" to "fastest moving" dimension, thus (h, w, 4). It's a Numpy/array programming convention. PIL, as an image library, not an array library, uses the more common image convention (w, h).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That makes sense, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think several days of my life have gone to sorting out (w, h) vs (r, c) issues!
This is one of the major selling points of
xray
.