Use facecolor instead of axisbg/axis_bgcolor #5501
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Partial fix for matplotlib#5309
|
Coveralls decreasing because of the creation of deprecated functions. Other than that, I think this is good to go. |
|
Add a test which checks the warnings come out? We don't do that all the time, but we probably should... |
|
Test added. |
pelson
added a commit
that referenced
this pull request
Nov 23, 2015
Use facecolor instead of axisbg/axis_bgcolor
mdboom
pushed a commit
to mdboom/matplotlib
that referenced
this pull request
Dec 11, 2015
Use facecolor instead of axisbg/axis_bgcolor
|
Backported to 2.0 as 5f1127c |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial fix for #5309 (the second bullet point).
This deprecates axisbg and axis_bgcolor (which are axis-specific properties) in favor of facecolor.