Fix #5281: Include ticks in tight bounding box #5502
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -568,7 +568,7 @@ def get_window_extent(self, renderer): | |||
| ignore=True) | |||
| # correct for marker size, if any | |||
| if self._marker: | |||
| ms = (self._markersize / 72.0 * self.figure.dpi) * 0.5 | |||
There was a problem hiding this comment.
What is this change for? I assume the issue is that with out this out ticks still get chopped?
There was a problem hiding this comment.
Yes. The assumption that markers only fill (-0.5, 0.5) is only true for circles. Ticks fill (0, 1) or (-1, 0) depending on "in" or "out".
|
Also breaks every single tight_layout test |
|
Not surprised it breaks tight layout tests. Will probably need to tie this change to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.