Skip to content

Raise a meaningful error message in @image_comparison decorator #5518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Raise a meaningful error message in @image_comparison decorator #5518

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a3875dd
Raise a meaningful error message to make the use of the @image_compar…
maxalbert Nov 19, 2015
8683f54
Change exception type back to AssertionError (in a somewhat shot-in-t…
maxalbert Nov 19, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion lib/matplotlib/testing/decorators.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,7 +360,12 @@ def _image_directories(func):
# namespace package pip installed and run via the nose
# multiprocess plugin or as a specific test this may be
# missing. See https://github.com/matplotlib/matplotlib/issues/3314
assert mods.pop(0) == 'tests'
if mods[0] != 'tests':
raise AssertionError(
"Test does not live in a submodule named 'tests'. Please make "
"sure that there is a parent directory named 'tests' and that "
"it contains a __init__.py file (can be empty).")
mods.pop(0) # ignore the leading 'tests' part of the module name
subdir = os.path.join(*mods)

import imp
Expand Down