Skip to content

WIP: updated defult boxplot styles #5523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from

Conversation

phobson
Copy link
Member

@phobson phobson commented Nov 19, 2015

I'm sort of flailing around at the moment.

Not exactly sure how you want the defaults modified. I just took at crack at the rcParams that are currently (see #5441) available.

@mdboom mdboom added this to the next major release (2.0) milestone Nov 19, 2015
@mdboom
Copy link
Member

mdboom commented Nov 19, 2015

Thanks. I'll incorporate this in the huge stack of other style changes we are doing for 2.0.

It might be helpful to update the test images in a separate commit so we can see and review the changes here...

@mdboom
Copy link
Member

mdboom commented Dec 14, 2015

Thanks. This for the most part looks good. The only change I would suggest is that instead of hardcoding b, which will always be blue, we should use [0] after #5674 (or something like it) is merged.

@phobson phobson force-pushed the default-boxplot-style branch 2 times, most recently from 922eef6 to 50e5ccb Compare December 14, 2015 18:56
@phobson phobson force-pushed the default-boxplot-style branch from 50e5ccb to 6101982 Compare February 18, 2016 23:34
@jenshnielsen jenshnielsen reopened this Mar 18, 2016
@tacaswell
Copy link
Member

ping @phobson The color cycle color selector is now merged (as 'C0', 'C1', ...)

@phobson
Copy link
Member Author

phobson commented Apr 28, 2016

thanks. @tacaswell. should I rebase off of master or 2.x?

@tacaswell
Copy link
Member

as this PR is against master, rebase on master

phobson added 2 commits April 28, 2016 08:52
Going for the Spinal Tap approach.

Q: How much blacker could the boxplots be?
A: A little, actually. I left some color in the
median line.
It was just "blue". Now it's [0] to pick out the
first color from the existing color cycle,
whatever that may be.
@phobson phobson force-pushed the default-boxplot-style branch from 6101982 to 11818d0 Compare April 28, 2016 16:00
@jenshnielsen
Copy link
Member

Looks like the image tests are not using the classic style so we will need to also update the test images or switch the boxplot image tests to use the classic style.

@phobson
Copy link
Member Author

phobson commented May 10, 2016

prefixed b2c8cca as "WIP" since:

  1. there's gotta be a better way; and
  2. there has to be some redundency with the style checking in Axes.boxplot. IOW, some of the style checking should be moved from boxplot to bxp.

I've add some TODO's to the original message up top

@phobson
Copy link
Member Author

phobson commented May 10, 2016

Just the test images:
b2d20e8

@tacaswell
Copy link
Member

Locally I am seeing

matplotlib/lib/matplotlib/__init__.py:1096: UserWarning: Bad val "auto" on line #341
        "boxplot.flierprops.markerfacecolor: auto
"
        in file "/home/tcaswell/source/p/matplotlib/lib/matplotlib/mpl-data/stylelib/classic.mplstyle"
        Key boxplot.flierprops.markerfacecolor: auto does not look like a color arg

@tacaswell
Copy link
Member

Closing this in favor of #6481

@tacaswell tacaswell closed this May 28, 2016
@phobson phobson deleted the default-boxplot-style branch March 28, 2017 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants