-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
WIP: updated defult boxplot styles #5523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks. I'll incorporate this in the huge stack of other style changes we are doing for 2.0. It might be helpful to update the test images in a separate commit so we can see and review the changes here... |
Thanks. This for the most part looks good. The only change I would suggest is that instead of hardcoding |
922eef6
to
50e5ccb
Compare
50e5ccb
to
6101982
Compare
ping @phobson The color cycle color selector is now merged (as |
thanks. @tacaswell. should I rebase off of master or 2.x? |
as this PR is against master, rebase on master |
Going for the Spinal Tap approach. Q: How much blacker could the boxplots be? A: A little, actually. I left some color in the median line.
It was just "blue". Now it's [0] to pick out the first color from the existing color cycle, whatever that may be.
6101982
to
11818d0
Compare
Looks like the image tests are not using the classic style so we will need to also update the test images or switch the boxplot image tests to use the classic style. |
prefixed b2c8cca as "WIP" since:
I've add some TODO's to the original message up top |
Just the test images: |
Locally I am seeing
|
Closing this in favor of #6481 |
I'm sort of flailing around at the moment.
Not exactly sure how you want the defaults modified. I just took at crack at the rcParams that are currently (see #5441) available.
bxp
andboxplot