Skip to content

Fixes #5522, bug in custom scale example #5533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 20, 2015
Merged

Fixes #5522, bug in custom scale example #5533

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e8e2ca4
Fixes custom scale example, see #5522
jeffrey-hokanson Nov 20, 2015
2025974
Fixing PEP8 compliance
jeffrey-hokanson Nov 20, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fixes custom scale example, see #5522 
Added the property has_inverse = True to the custom scale example
so that if axhline is later called on this axis an error is not
produced.
  • Loading branch information
@jeffrey-hokanson
jeffrey-hokanson committed Nov 20, 2015
commit e8e2ca41f663c6a66b74f1909ee8a58aa5be3072
3 changes: 2 additions & 1 deletion examples/api/custom_scale_example.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ class MercatorLatitudeTransform(mtransforms.Transform):
input_dims = 1
output_dims = 1
is_separable = True

has_inverse = True
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a PEP8 nitpick here: Insert a blank space before the method definition.

def __init__(self, thresh):
mtransforms.Transform.__init__(self)
self.thresh = thresh
Expand Down Expand Up @@ -138,6 +138,7 @@ class InvertedMercatorLatitudeTransform(mtransforms.Transform):
input_dims = 1
output_dims = 1
is_separable = True
has_inverse = True

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've fixed this and the file appears clear upon running pep8. Is there something else I'm missing?

def __init__(self, thresh):
mtransforms.Transform.__init__(self)
Expand Down