ENH: errorbar color cycle clean up #5593
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great -- this definitely addresses part of #5584 in a better way. Should we also remove the use of |
e538f5b to
3e53330
Compare
Instead of using calls to `plt.plot`
ddde346 to
c8a365a
Compare
Need 3 internal style dictionaries: - eb_lines_style : used for the line collections - eb_cap_style : base style to be used for the bar 'caps' - plot_line_style : used from the 'main' line
|
The decision to consult the prop-cycle still needs to be fixed. attn @WeatherGod |
|
and is this a 2.0 or 2.1 tagged issue? |
| uplims = np.asarray(uplims, bool) | ||
| if plot_line: | ||
| l0 = mlines.Line2D(x, y, **plot_line_style) | ||
| self.add_line(l0) |
There was a problem hiding this comment.
Nitpick this variable name looks a bit to close to 10 I first read the line as self.add_line(10)
There was a problem hiding this comment.
Indeed, will fix that.
|
👍 @tacaswell Does this need more work ([WIP] in the title) of is it ready? |
'l0' (el-zero) looks too much like 10 (ten) to be used as a variable name.
751d108 to
2338e2e
Compare
|
This should be ready to go. |
jenshnielsen
added a commit
to jenshnielsen/matplotlib
that referenced
this pull request
May 30, 2016
ENH: errorbar color cycle clean up
|
Back port to 2.x as acfab37 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mdboom This is what I was talking about on the phone call.