Skip to content

Update banner logo on main website #5653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 15, 2015
Merged

Update banner logo on main website #5653

merged 1 commit into from
Dec 15, 2015

Conversation

mdboom
Copy link
Member

@mdboom mdboom commented Dec 10, 2015

This updates the banner logo on the index.html of the website to the new logo we've been making stickers of for about a year.

I know there are plans afoot to do more drastic things to the website, but this is an easy thing we can do now that looks a lot cleaner than what we currently have.

@mdboom mdboom added this to the next major release (2.0) milestone Dec 10, 2015
@tacaswell
Copy link
Member

the gh preview of the svg is cropped, I hope that is just gh doing a bad job rendering?

@mdboom
Copy link
Member Author

mdboom commented Dec 10, 2015

This is what the github preview looks like for me:

screen shot 2015-12-10 at 3 13 14 pm

tacaswell added a commit that referenced this pull request Dec 15, 2015
@tacaswell
Merge pull request #5653 from mdboom/update-logo
ca93a06 
DOC: Update banner logo on main website
@tacaswell tacaswell merged commit ca93a06 into matplotlib:master Dec 15, 2015
tacaswell added a commit that referenced this pull request Dec 15, 2015
@tacaswell
Merge pull request #5653 from mdboom/update-logo
325e47b 
DOC: Update banner logo on main website
@tacaswell
Copy link
Member

backported to v1.5.0-doc as 325e47b

@jenshnielsen jenshnielsen mentioned this pull request Dec 29, 2015
Merged
@WeatherGod
Copy link
Member

Viewing the devdocs using Firefox 43 on Ubuntu, the banner looks cropped and the radar chart logo is misplaced.

@jenshnielsen
Copy link
Member

Confirming. It looks good in Firefox on OSX but broken in firefox on Ubuntu 15.10 (virtual machine)

@jenshnielsen
Copy link
Member

screenshot from 2015-12-29 15-58-14

This is rendering only the svg image

@WeatherGod
Copy link
Member

yup, that is what it looks like to me.

@mdboom
Copy link
Member Author

mdboom commented Dec 29, 2015

Sorry, guys. Amateur mistake. We should convert the text to paths, since we don't ship that font. (It looks fine for me, because I have the font installed). I'll have a PR shortly.

@mdboom mdboom mentioned this pull request Dec 29, 2015
Merged
@cgohlke
Copy link
Contributor

cgohlke commented Jan 11, 2016

BTW, the SVG file breaks the Microsoft Compiled HTML Help (CHM) file. HTML Help control and SumatraPDF display a white placeholder of 540x617 px instead of the logo. xCHM does not render SVG either.

@mdboom
Copy link
Member Author

mdboom commented Jan 12, 2016

BTW, the SVG file breaks the Microsoft Compiled HTML Help (CHM) file. HTML Help control and SumatraPDF display a white placeholder of 540x617 px instead of the logo. xCHM does not render SVG either.

We'll probably need to add a PNG fallback for that case. Since I don't have the tooling to validate a CHM, is this something you could do?

@cgohlke cgohlke mentioned this pull request Jun 3, 2016
Merged
@QuLogic QuLogic modified the milestones: v1.5.1, 2.0 (style change major release) Oct 16, 2016
@QuLogic QuLogic mentioned this pull request May 9, 2019
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.5.1
Development

Successfully merging this pull request may close these issues.
6 participants
@mdboom @tacaswell @WeatherGod @jenshnielsen @cgohlke @QuLogic