Skip to content

BUG: handle colorbar ticks with boundaries and NoNorm; closes #5673 #5700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 20, 2015

Conversation

efiring
Copy link
Member

@efiring efiring commented Dec 20, 2015

No description provided.

The change to contour_manual_colors_and_levels is clear: it is now
including ticks that should have been there all along.
The change to double_cbar is almost imperceptible, but I suspect it
is also the addition of a tick that was previously missing.
tacaswell added a commit that referenced this pull request Dec 20, 2015
BUG: handle colorbar ticks with boundaries and NoNorm; closes #5673
@tacaswell tacaswell merged commit 497ffa8 into matplotlib:master Dec 20, 2015
tacaswell added a commit that referenced this pull request Dec 20, 2015
BUG: handle colorbar ticks with boundaries and NoNorm; closes #5673

used master branch pngs
@tacaswell
Copy link
Member

backported to 1.5.x as f19fea6

It looks like in 164222a these images were changed to include the regression. I had issues trying to get the pngs on this PR to show up as changed in the cherry-pick.

https://github.com/matplotlib/matplotlib/blob/v1.5.x/lib/matplotlib/tests/baseline_images/test_contour/contour_manual_colors_and_levels.png

https://github.com/matplotlib/matplotlib/blob/v1.5.x/lib/matplotlib/tests/baseline_images/test_colorbar/double_cbar.png

both look correct.

@QuLogic QuLogic added this to the Critical bugfix release (1.5.1) milestone Dec 21, 2015
tacaswell added a commit that referenced this pull request Dec 21, 2015
BUG: handle colorbar ticks with boundaries and NoNorm; closes #5673
@tacaswell
Copy link
Member

also had to be backported to 2.x which already had the code changes merged in to move the test image changes.

4fd5f55

@efiring efiring deleted the colorbar_tick_trim branch June 23, 2016 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants