Build docs on python3.5 with linkcheck running on python 2.7 #5797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9fa3b3d to
5edf56f
Compare
| @@ -86,8 +86,7 @@ install: | |||
|
|
|||
| - | | |||
| if [[ $BUILD_DOCS == true ]]; then | |||
| pip install $PRE numpydoc ipython jsonschema mistune colorspacious | |||
| pip install -q $PRE linkchecker | |||
| pip install $PRE numpydoc ipython colorspacious | |||
There was a problem hiding this comment.
I have removed jsonshema and mistune they are not needed anymore. They were only there because ipython had a bud in its dependencies
|
In terms of catching bugs in and triggered by the examples, would it make sense to build the docs in both Py3 and Py2 (in separate Travis configs so they run in parallel)? |
|
I have thought about that and it probably would. It's of cause a tradeoff between the time spend on building the docs vs how much more coverage it gives. Perhaps we should only do that after #5597 is merged? |
tacaswell
added a commit
that referenced
this pull request
Jan 6, 2016
Build docs on python3.5 with linkcheck running on python 2.7
This was referenced Jan 6, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative to #5338 which runs the yet not python 3.5 compatible linkchecker on python 2.7 but builds the docs with python 3.5